Skip to content

Coverage cleanup#269

Merged
eugenevinitsky merged 11 commits intomasterfrom
coverage_cleanup
Nov 28, 2018
Merged

Coverage cleanup#269
eugenevinitsky merged 11 commits intomasterfrom
coverage_cleanup

Conversation

@AboudyKreidieh
Copy link
Copy Markdown
Member

@AboudyKreidieh AboudyKreidieh commented Nov 20, 2018

changes:

  • added ignores to the coverage to if __name__ == '__main__': and raise NotImplementedError
  • minor cleanup to tests to improve coverage
  • added ignores to everything rllab-related

@coveralls
Copy link
Copy Markdown

coveralls commented Nov 20, 2018

Pull Request Test Coverage Report for Build 1645

  • 16 of 16 (100.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+5.05%) to 84.491%

Files with Coverage Reduction New Missed Lines %
flow/envs/bay_bridge/base.py 2 64.1%
Totals Coverage Status
Change from base Build 1639: 5.05%
Covered Lines: 6679
Relevant Lines: 7905

💛 - Coveralls

Copy link
Copy Markdown
Member

@eugenevinitsky eugenevinitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly a good thing.

@eugenevinitsky eugenevinitsky merged commit 21144b7 into master Nov 28, 2018
@eugenevinitsky eugenevinitsky deleted the coverage_cleanup branch November 28, 2018 05:10
crystalzyan pushed a commit to crystalzyan/flow that referenced this pull request Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants